Refactor unnecessary else / elif when if block has a return statement

This commit is contained in:
deepsource-autofix[bot]
2021-12-26 05:05:38 +00:00
committed by GitHub
parent 414c8babeb
commit 129fb92511
3 changed files with 40 additions and 45 deletions

View File

@@ -169,33 +169,32 @@ class AbsChunkedInputStream(io.BytesIO, HaltListener):
buffer.seek(0)
self.__pos += buffer.getbuffer().nbytes
return buffer.read()
else:
buffer = io.BytesIO()
chunk = int(self.__pos / (128 * 1024))
chunk_off = int(self.__pos % (128 * 1024))
chunk_end = int(__size / (128 * 1024))
chunk_end_off = int(__size % (128 * 1024))
if chunk_end > self.size():
chunk_end = int(self.size() / (128 * 1024))
chunk_end_off = int(self.size() % (128 * 1024))
if chunk_off + __size > len(self.buffer()[chunk]):
buffer = io.BytesIO()
chunk = int(self.__pos / (128 * 1024))
chunk_off = int(self.__pos % (128 * 1024))
chunk_end = int(__size / (128 * 1024))
chunk_end_off = int(__size % (128 * 1024))
if chunk_end > self.size():
chunk_end = int(self.size() / (128 * 1024))
chunk_end_off = int(self.size() % (128 * 1024))
if chunk_off + __size > len(self.buffer()[chunk]):
self.check_availability(chunk, True, False)
buffer.write(self.buffer()[chunk][chunk_off:])
chunk += 1
while chunk <= chunk_end:
self.check_availability(chunk, True, False)
buffer.write(self.buffer()[chunk][chunk_off:])
if chunk == chunk_end:
buffer.write(self.buffer()[chunk][:chunk_end_off])
else:
buffer.write(self.buffer()[chunk])
chunk += 1
while chunk <= chunk_end:
self.check_availability(chunk, True, False)
if chunk == chunk_end:
buffer.write(self.buffer()[chunk][:chunk_end_off])
else:
buffer.write(self.buffer()[chunk])
chunk += 1
else:
self.check_availability(chunk, True, False)
buffer.write(self.buffer()[chunk][chunk_off:chunk_off +
__size])
buffer.seek(0)
self.__pos += buffer.getbuffer().nbytes
return buffer.read()
else:
self.check_availability(chunk, True, False)
buffer.write(self.buffer()[chunk][chunk_off:chunk_off +
__size])
buffer.seek(0)
self.__pos += buffer.getbuffer().nbytes
return buffer.read()
def notify_chunk_available(self, index: int) -> None:
self.available_chunks()[index] = True
@@ -718,11 +717,10 @@ class PlayableContentFeeder:
if type(playable_id) is TrackId:
return self.load_track(playable_id, audio_quality_picker, preload,
halt_listener)
elif type(playable_id) is EpisodeId:
if type(playable_id) is EpisodeId:
return self.load_episode(playable_id, audio_quality_picker,
preload, halt_listener)
else:
raise TypeError("Unknown content: {}".format(playable_id))
raise TypeError("Unknown content: {}".format(playable_id))
def load_stream(self, file: Metadata.AudioFile, track: Metadata.Track,
episode: Metadata.Episode, preload: bool,
@@ -736,7 +734,7 @@ class PlayableContentFeeder:
response, preload, halt_lister)
return CdnFeedHelper.load_episode(self.__session, episode, file,
response, preload, halt_lister)
elif response.result == StorageResolve.StorageResolveResponse.Result.STORAGE:
if response.result == StorageResolve.StorageResolveResponse.Result.STORAGE:
if track is None:
pass
elif response.result == StorageResolve.StorageResolveResponse.Result.RESTRICTED:
@@ -753,14 +751,13 @@ class PlayableContentFeeder:
if episode.external_url:
return CdnFeedHelper.load_episode_external(self.__session, episode,
halt_listener)
else:
file = audio_quality_picker.get_file(episode.audio)
if file is None:
self.logger.fatal(
"Couldn't find any suitable audio file, available: {}".
format(episode.audio))
return self.load_stream(file, None, episode, preload,
halt_listener)
file = audio_quality_picker.get_file(episode.audio)
if file is None:
self.logger.fatal(
"Couldn't find any suitable audio file, available: {}".
format(episode.audio))
return self.load_stream(file, None, episode, preload,
halt_listener)
def load_track(self, track_id_or_track: typing.Union[TrackId,
Metadata.Track],